Skip to content

fix(webapp): load pyodide in app#369

Merged
henryiii merged 2 commits into
mainfrom
henryiii/fix/pyodideload
Apr 14, 2026
Merged

fix(webapp): load pyodide in app#369
henryiii merged 2 commits into
mainfrom
henryiii/fix/pyodideload

Conversation

@henryiii
Copy link
Copy Markdown
Collaborator

@henryiii henryiii commented Apr 6, 2026

No longer required for users to load separately.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/pyodideload branch from 6ca4c71 to e888c5d Compare April 6, 2026 05:31
@henryiii henryiii requested a review from Copilot April 6, 2026 05:33
@henryiii henryiii marked this pull request as ready for review April 6, 2026 05:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repo-review webapp so it no longer relies on the host page (or docs pages) to pre-load Pyodide via a <script> tag, instead loading Pyodide from the CDN at runtime within the app.

Changes:

  • Load Pyodide dynamically from jsDelivr at runtime in the webapp utility code.
  • Remove Pyodide <script> tags from the app HTML entrypoint and documentation pages/examples.
  • Enable JSON imports in TypeScript config and move pyodide to runtime dependencies to support version-based CDN loading.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tsconfig.json Enables resolveJsonModule to allow importing pyodide/package.json for versioning.
src/repo-review-app/utils/pyodide.ts Switches from global window.loadPyodide to dynamic import from a versioned CDN URL.
src/repo-review-app/index.html Removes the explicit Pyodide CDN <script> tag.
package.json Moves pyodide into dependencies (needed at runtime for version resolution).
docs/webapp.md Updates embedding/bundling notes to reflect automatic Pyodide loading.
docs/live-demo.md Removes the explicit Pyodide CDN <script> tag from the live demo doc page.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/repo-review-app/utils/pyodide.ts Outdated
Comment thread src/repo-review-app/utils/pyodide.ts Outdated
Assisted-by: OpenCode:Kimi-K2.5
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
@henryiii henryiii merged commit 4d4abb4 into main Apr 14, 2026
13 checks passed
@henryiii henryiii deleted the henryiii/fix/pyodideload branch April 14, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants