fix(webapp): load pyodide in app#369
Merged
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
6ca4c71 to
e888c5d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo-review webapp so it no longer relies on the host page (or docs pages) to pre-load Pyodide via a <script> tag, instead loading Pyodide from the CDN at runtime within the app.
Changes:
- Load Pyodide dynamically from jsDelivr at runtime in the webapp utility code.
- Remove Pyodide
<script>tags from the app HTML entrypoint and documentation pages/examples. - Enable JSON imports in TypeScript config and move
pyodideto runtime dependencies to support version-based CDN loading.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Enables resolveJsonModule to allow importing pyodide/package.json for versioning. |
| src/repo-review-app/utils/pyodide.ts | Switches from global window.loadPyodide to dynamic import from a versioned CDN URL. |
| src/repo-review-app/index.html | Removes the explicit Pyodide CDN <script> tag. |
| package.json | Moves pyodide into dependencies (needed at runtime for version resolution). |
| docs/webapp.md | Updates embedding/bundling notes to reflect automatic Pyodide loading. |
| docs/live-demo.md | Removes the explicit Pyodide CDN <script> tag from the live demo doc page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assisted-by: OpenCode:Kimi-K2.5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer required for users to load separately.