Merged
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
jarrodmillman
approved these changes
Jul 21, 2022
Member
|
Thanks! This LGTM. I would like to see if @stefanv has any suggestions before merging. So let's give this another day or so. |
Member
|
I think @InessaPawson @isabela-pf @MarsBarLee already approved this; but if at least one of you could review this, I would appreciate it. Thanks!! |
InessaPawson
approved these changes
Jul 23, 2022
Member
InessaPawson
left a comment
InessaPawson
left a comment
There was a problem hiding this comment.
LGTM. Thank you for working on this, @AsavariA!
Member
|
Thanks @AsavariA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with issue #187
and issue #441 of the numpy.org repository.
This PR solves this issue in this way -
color - colorSecondary
color on hover - white(#fff)
size - 2.3em (which was previously 1.5em, anything greater than that seems too big and out of proportion)