Skip to content

Use SASS variables for color names#48

Merged
jarrodmillman merged 1 commit intoscientific-python:mainfrom
stefanv:color-variables
Oct 28, 2021
Merged

Use SASS variables for color names#48
jarrodmillman merged 1 commit intoscientific-python:mainfrom
stefanv:color-variables

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented Oct 28, 2021

If we want to make colors customizable, we can later grab these from .Site.Params.

NOTE: This removes the styling used for the NumPy and SciPy "subscribed to mailing list" feature, which will have to be added back on those sites by hand. Alternative: make the subscribing to mailchimp a feature of the theme.

The styles that need to be returned:

Details
$numpySlateGray := rgb(108, 122, 137);

.sign-up-container {
  display: flex;
  flex-direction: row;
  align-items: center;
  position: relative;
  height: 75px;
}

.sign-up-image {
  padding: 5px 10px 6px 10px;
  border-right: 1px solid $colorPrimaryLight;
  background-color: $colorPrimaryLight;
  border-radius: 5px 0 0 5px;
}

.sign-up-input {
  background-color: $colorPrimaryLight;
  border-radius: 0 5px 5px 0;
  border: none;
  width: 75%;
  height: 35px;
  padding-left: 5px;
  font-size: 14px;
  color: $colorPrimaryDark;
}

.submission-instructions {
  position: absolute;
  right: 18%;
  font-size: 10px;
  color: $numpySlateGray;
}

.signup-button {
  display: none;
}

.thank-you {
  display: none;
  height: 75px;
  color: $colorPrimaryLight;
  align-items: center;
  color: $colorPrimaryLight;
}

@media only screen and (max-width: 1150px) {
  .sign-up-input {
    font-size: 12px;
  }
}

@media only screen and (max-width: 850px) {
  .sign-up-input {
    width: 100%;
  }

  .thank-you {
    justify-content: center;
  }

  .submission-instructions {
    display: none;
  }

  .signup-button {
    display: block;
    height: 35px;
    border-radius: 5px;
    margin-left: 5px;
    width: 60px;
    color: black;
    border:none;
    outline:none;
  }
}

If we want to make colors customizable, we can later grab these from .Site.Params.
@jarrodmillman jarrodmillman merged commit ad01dba into scientific-python:main Oct 28, 2021
@stefanv stefanv mentioned this pull request Oct 29, 2021
@jarrodmillman jarrodmillman added this to the 0.1 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants