Skip to content

Moved monthly meeting to first week of the month#343

Merged
stefanv merged 6 commits intoscientific-python:mainfrom
noatamir:update-mpl-calendar
Nov 2, 2022
Merged

Moved monthly meeting to first week of the month#343
stefanv merged 6 commits intoscientific-python:mainfrom
noatamir:update-mpl-calendar

Conversation

@noatamir
Copy link
Copy Markdown
Contributor

@noatamir noatamir commented Nov 2, 2022

@tupui I may have asked this before. But is it possible to set a meeting to be on the first week of the month rather than on a 4 week interval to avoid this sliding effect? It would reduce maintenance on the calendar for monthly meetings ☺️

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 2, 2022

Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a34d6e3
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-org/deploys/6362e13bfb72670008e623ee
😎 Deploy Preview https://deploy-preview-343--scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you can now, see the tests in scientific-python/yaml2ics#41

@noatamir
Copy link
Copy Markdown
Contributor Author

noatamir commented Nov 2, 2022

Wait, doesn't that solve the external url issue? for projects like pandas that need a gcal based event? (which I am happy to add now!)
How do I do a custom RRULE for first week of the month using this notation? I don't have a custom ics for Matplotlib 🤔

@noatamir
Copy link
Copy Markdown
Contributor Author

noatamir commented Nov 2, 2022

Ah I just found this on the other PR it was linking to! Never mind =) RRULE:FREQ=MONTHLY;BYDAY=1WE

@tupui
Copy link
Copy Markdown
Member

tupui commented Nov 2, 2022

You have an example of rule in the PR I linked. Otherwise from a quick search https://stackoverflow.com/questions/10767018/rule-to-represent-the-first-full-week-of-the-month

Otherwise we still don't support external ics files to be used there.

Comment thread calendars/matplotlib.yaml Outdated
Comment thread calendars/matplotlib.yaml Outdated
@tupui
Copy link
Copy Markdown
Member

tupui commented Nov 2, 2022

@noatamir CI is green now, does the preview look good so I can merge?

@noatamir
Copy link
Copy Markdown
Contributor Author

noatamir commented Nov 2, 2022

Thanks @tupui!
For some reason, the event appears on Wednesdays and not on Tuesdays. I set the first one on December 6th which is a Tuesday. Should I move it back one day?

@tupui
Copy link
Copy Markdown
Member

tupui commented Nov 2, 2022

@noatamir I don't know, you might want to test this locally by just running yaml2ics matplotlib.yaml and check the ICS.

@stefanv
Copy link
Copy Markdown
Member

stefanv commented Nov 2, 2022

For some reason, the event appears on Wednesdays and not on Tuesdays. I set the first one on December 6th which is a Tuesday. Should I move it back one day?

The RRULE says RRULE:FREQ=MONTHLY;BYDAY=1WE, so Wednesday would be correct, no?

@noatamir
Copy link
Copy Markdown
Contributor Author

noatamir commented Nov 2, 2022

I thought that was short for first week 🤦‍♀️. Ok this is an easy fix.

Copy link
Copy Markdown
Contributor Author

@noatamir noatamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix day of week

Comment thread calendars/matplotlib.yaml Outdated
@stefanv stefanv merged commit 5fdbbb3 into scientific-python:main Nov 2, 2022
@noatamir
Copy link
Copy Markdown
Contributor Author

noatamir commented Nov 2, 2022

Thanks @tupui and @stefanv 🌷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants