Fix rrule creation: use name= and value= for more correct syntax. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When trying to make the rrule, I was getting import errors in Thunderbird locally, + the online icalendar verifier. (These changes have not yet been tested for the online calendars. I also wondered if the online calendars would be more relaxed in parsing it, so that it would work). - The rrule had a trailing ':', since it was parsed as NAME:VALUE with all of the rrule in NAME only, leaving the ':' on the end. - Now, split the rrule on ':' (maxsplit=1), and make the ics.ContentLine with the 'name=[left side]', 'value=[right side]'. This leaves the colon in the right place. - This makes the generated ics pass the validator and work locally in Thunderbird. If it doesn't work with online calendars, I will update this PR with that information. - Review: worth someone looking to see if this is reasonable, but I think there is little chance of anything being made worse than it was before.
Member
|
Thank you @rkdarst! I'd also like to point out ics-py/ics-py#307 for online use, in case you're interested. |
rkdarst
added a commit
to rkdarst/yaml2ics
that referenced
this pull request
Jan 23, 2022
- Add as NAME: to the top-level calendar, as mentioned in scientific-python#6 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to make the rrule, I was getting import errors in
Thunderbird locally, + the online icalendar verifier. (These
changes have not yet been tested for the online calendars. I also
wondered if the online calendars would be more relaxed in parsing
it, so that it would work).
The rrule had a trailing ':', since it was parsed as NAME:VALUE with
all of the rrule in NAME only, leaving the ':' on the end.
Now, split the rrule on ':' (maxsplit=1), and make the
ics.ContentLine with the 'name=[left side]', 'value=[right side]'.
This leaves the colon in the right place.
This makes the generated ics pass the validator and work locally in
Thunderbird. If it doesn't work with online calendars, I will
update this PR with that information.
Review: worth someone looking to see if this is reasonable, but I
think there is little chance of anything being made worse than it
was before.