Skip to content

Add command line for computing CSF and intracranial masks#43

Merged
finsberg merged 13 commits into
mainfrom
cecile/masks
Apr 16, 2026
Merged

Add command line for computing CSF and intracranial masks#43
finsberg merged 13 commits into
mainfrom
cecile/masks

Conversation

@cdaversin
Copy link
Copy Markdown
Collaborator

No description provided.

@cdaversin cdaversin requested a review from finsberg April 14, 2026 13:06
Copy link
Copy Markdown
Member

@finsberg finsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should also add some tests which test this on the gonzo dataset. Do we have the csf masks generated in the dataset? Also it might be good to add a bit more information about the input image to the csf mask parser. Right now it sais "Path to the input NIfTI image", but can this be any input image. From the docstring in compute_csf_mask_array it looks like it should be either T2w or Spin-Echo?

Similar to the other PR (#41), I think it is better to save the output file in the dispatch function. That way, we can get rid of the output argument to the functions and the functions does only one thing.

@cdaversin
Copy link
Copy Markdown
Collaborator Author

Indeed. we have the csf/intracranial masks in the gonzo dataset, I have now added the corresponding tests and also some dispatch tests to be consistent with what is done in test_looklocker for example.

I also updated the "help" message describing the input for the CSF mask, and removed the outputargument from the functions.

@finsberg finsberg merged commit e1d18cb into main Apr 16, 2026
23 checks passed
@finsberg finsberg deleted the cecile/masks branch April 16, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants