Skip to content

Various fixes#47

Merged
cdaversin merged 4 commits intocecile/segmentation_refinementfrom
finsberg/segmentation_refinement
Apr 25, 2026
Merged

Various fixes#47
cdaversin merged 4 commits intocecile/segmentation_refinementfrom
finsberg/segmentation_refinement

Conversation

@finsberg
Copy link
Copy Markdown
Member

@finsberg finsberg commented Apr 24, 2026 •
edited
Loading

  • Adding save method to Segmentation (which also saved the lut in a json file)
  • Make from_file in Segmentation also take lut_path as optional.
  • Fix some bugs from then Segmentation was a subclass of MRIData
  • Fix shape issue in refinement test
  • Use gonzo roi in csf segmentation test
  • Added file sub-01_ses-01_T1w_registered.nii.gz

@finsberg finsberg marked this pull request as ready for review April 24, 2026 18:59
@finsberg finsberg requested a review from cdaversin April 24, 2026 18:59
cdaversin
cdaversin approved these changes Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cdaversin cdaversin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @finsberg (that's exactly the fixes I was about to work on now 😄)

@cdaversin cdaversin merged commit 202e909 into cecile/segmentation_refinement Apr 25, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdaversin cdaversin cdaversin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@finsberg @cdaversin