Fiji won't quit when using SJC >= 2.93.0 #463
Description
Potentially with the addition of this commit, when running Fiji the shutdown process now takes significantly longer to actually complete.
This makes it possible to do horrible things like click the "X" to close Fiji multiple times.
When this happens, Fiji does the opposite and does not quit at all.
MCVE on Windows with an up-to-date Fiji 2.9.0:
- Replace
jars/scijava-common-2.90.1.jarwithscijava-common-2.93.0or newer - Launch Fiji (easiest to see if done from the command line, e.g.
./ImageJ-win64.exe) - Search for something in the search bar (if this step is omitted, the shutdown process is too quick)
- Click the "X" multiple times to close Fiji
Eventually the GUI will disappear but the process will continue. It doesn't respond to kill signals from the terminal for me, but had to be Ctrl+Alt+Deleted.
Adding -Dscijava.log.level=debug did not show any stack trace.
Under normal shutdown conditions I see this message:
OpenJDK 64-Bit Server VM warning: ignoring option PermSize=128m; support was removed in 8.0
OpenJDK 64-Bit Server VM warning: Using incremental CMS is deprecated and will likely be removed in a future release
which is not shown if Fiji gets stuck.
Notes
Also tested with jgo sc.fiji:fiji:2.12.0+org.scijava:scijava-common:2.94.0 but when running from jgo, and not the native launcher, the shutdown process is too fast to get multiple clicks in.
When testing with the native launcher and SJC <=2.92.0, shutdown was too fast to get multiple clicks in.