ConvertService #108
Merged
ConvertService #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new HandlerService: ConversionService, operating on ConversionHandler plugins. The purpose of these handlers is to process a new class, "ConversionRequest", which signifies the desire to cast or convert an object of one type to another. This will take the place of ConversionUtils, as it is an extensible framework. ConversionHandler plugins can decide what types of conversion they support and thus override the default behavior (the default plugin supports primitive : object conversions and cases where the destination object has a constructor that will accept the source, for example). Closes #95
The ConversionUtils canConvert and convert methods will now all delegate to a ConversionService, if available, or a DefaultConversionHandler if no ConversionService has been set. The ConversionUtils class will be retained, as it provides some API which does not need generalization via a Service/plugin framework. All delegating methods have been marked deprecated however, and consumers should switch to ConversionService usage if possible. Updated the AbstractConversionService so that ConversionServices set themselves as the delegate service in CovnersionUtils on initialization (only the highest priority will "stick").
All Contextual consumers of ConversionUtils are now updated to use the ConversionService when appropriate. Also updated the ConversionUtilsTest to make private test classes public.
* package is now org.scijava.convert. Shouldn't have been a subpackage of *.util. * ConversionHandler is now just a Converter, to imply action. * ConversionService is now just ConvertService.
ctrueden
added a commit
that referenced
this pull request
Jul 25, 2014
Refactors the conversion methods of ConversionUtils to an extensible, Handler-patterned ConvertService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the conversion methods of
ConversionUtilsto an extensible,Handler-patternedConvertService.