Conversation
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Looks great! I wrote some nitpicks. Please fix, and we can merge it!
There was a problem hiding this comment.
Let's use byte array handles, instead of files. No need to waste disk I/O for this one.
There was a problem hiding this comment.
You use underscore in numeric constant above, but not here. Let's be consistent!
There was a problem hiding this comment.
Let's make this non-static. I.e.: spin a new context in @Before rather than using @BeforeClass and potentially bleeding state between tests.
| @@ -0,0 +1,135 @@ | |||
|
|
|||
There was a problem hiding this comment.
Need to write when the exception is thrown.
There was a problem hiding this comment.
Should state here that 0 means all bytes, same as in the other signature.
| * | ||
| * @param in input handle | ||
| * @param out the output handle | ||
| * @param length maximum number of bytes to copy, will copy all bytes if set |
There was a problem hiding this comment.
More grammatically correct would be ; instead of ,. Otherwise it's a comma splice.
There was a problem hiding this comment.
You can achieve final on this variable if you structure this section a little more carefully.
There was a problem hiding this comment.
Should use curly braces for the consequent here, so formatter does the right thing.
Allows for easy copying from one handle to another.
gab1one
force-pushed
the
datahandles-copy
branch
from
60ad2a5 to
fbbc76c
Compare
|
@ctrueden I updated the pr with all the changes you requested. |
|
Thanks!! |
2 participants
Adds a new method to the DataHandles class that allows for easy copying using an internal buffer