Merged
Conversation
bda08b2 to
fbdb08b
Compare
Also add minimal test for array types with generics. See scijava#415
fbdb08b to
cfe7db4
Compare
Member
|
@hinerm if you find the time, may I ask you to have a look at this? See the linked issues for context. |
Member
|
This was a delightfully effortless PR to review and merge. Thank you so much @imagejan, @NicoKiaru, @frauzufall! |
Member
Contributor
Author
|
@hinerm do you know if this fix made its way in pom-scijava 30.0.0 ? Or is it planned for 30.0.1 ? Or is it unrelated ? |
Member
|
@NicoKiaru if you click on the merge commit of this PR (c7aa9f4), you'll see only ... meaning that this commit is not (yet) part of any release of |
Contributor
Author
|
Thanks as always @imagejan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a test that reproduces the issue #415
The test CommandArrayConverterTest#testArrayConvertFromStringCommandWildcardGenerics currently fails