Fix incompatibility to new scijava LogService#2
Fix incompatibility to new scijava LogService#2ctrueden merged 2 commits intoscijava:masterfrom maarzt:log-service-revamp
Conversation
|
Thanks @maarzt. I am releasing scijava-common 2.67.0 now (there was new API added, so a minor version bump was necessary). Please rebase this branch to eliminate the WIP:
It should then be the case that all commits compile with passing tests; the |
|
Thanks for releasing the new scijava-common version. I did the rebase as you described.
Should I squash the two commits? |
Sure, that's usually what we do when code changes need to happen concurrently with a dependency version update. So squashing the first two commits together, and keeping the second commit message, sounds great. Thanks. One small typo in the message: |
SLF4JLogService had no implementation for methodes that were added to LogService in scijava-common version 2.66.1. SLF4JLogService now implements all required methods because it extends AbstractLogService.
|
I think this branch is ready to be merged |
|
Thanks @maarzt! |
Add implementations for the methods that were recently added to LogService.
A new version of scijva-log-slf4j containing this changes should be released together with scijava-common 2.66.2.