Move op index & others

[wiedenm]

This PR comprises a set of rather loosely related changes. The main topics are:

• More explicit decoupling of the individual parts of the matching infrastructure (Op discovery & indexing, Transformer indexing & matching)
• Treat former Op aliases as "proper" Op names
• Reduce dependencies on plugin/service infrastructure
• Disable prefix search. See OpService's prefix search does not work when parts of prefix are "empty" #20.

Feel free to approve or reject these changes separately.

The PR does not yet deal with the removal of all parts of the plugin system. OpService and TypeService still exist and use other services internally. In particular, OpService still relies on PluginService to collect Ops and Transformers.

[wiedenm]

The diffs of DefaultOpTypeMatchingService and DefaultOpTransformerService got polluted by formatting and might be a bit hard to read, sorry about that. I should be using the eclipse preferences from imagej/imagej - are those the right ones?

[ctrueden]

I should be using the eclipse preferences from imagej/imagej - are those the right ones?

You and @gselzer should just stop autoformatting on save. It creates tons of problems. We can try to fix the autoformatters but it is low priority. If you want to format a code block that you just wrote, select it and then shift+ctrl+F it.

It is possible to split these muddy commits using git rebase -i with some care. I can show you a couple of approaches I use early next week, if you like.

[wiedenm]

Yes, I usually turn off save actions when working on already existing files and only use them for new files, forgot it here. I know about Shift+Ctrl+F, I mostly use save actions for clean-ups (making variables final etc.). It's a pity that there's no Shift+Ctrl+F equivalent for that.

Sounds good, thanks!

[ctrueden]

It's a pity that there's no Shift+Ctrl+F equivalent for that.

For Clean Up, I usually type (on macOS): option+command+S and then C,C,return. Yeah, no official shortcut, but it's still quite fast. Unfortunately, I believe Clean Up is always global to the file, rather than operating on the current selection, so it will not help you here. This is why you see me adding final keywords by hand sometimes.

[wiedenm]

Cleaned up the diffs some more, the PR should be ready for review now.

[ctrueden]

Darn, I completely forgot about this PR, and since then work continued on the migrate-imagej-ops branch, with @gselzer redoing some of the work you had already done here.

I have now reconciled the branches, fixing conflicts, etc. Some of the work here might was lost: in particular, the separation of the op index into its own OpIndex class. But because the op index was still simplified to a map instead of a tree data structure, it is not so terrible leaving it in the OpService for now. We should still separate it at some point soon. Also, the goal of keeping the iteration order consistent and sorted is probably not met now—@gselzer just used a normal HashMap rather than anything fancy like TreeMap (always sorted) or LinkedHashMap (preserves insertion order).

Anyway, all commits compile with passing tests, and are still a step forward, so I'll merge it now.