Pass match rather than pattern argument to files() #18
Conversation
The pattern argument to listdir() has been deprecated in favor of the match argument. They don't function in the exact same way as match expects a callable that will be used for matching.
|
The Python 3.6 tests fail due to an issue between |
|
@thewtex Funny, I was looking at this at this very moment. @kjerstadius Thanks for the patch 👍 and thanks for the forensic work. To address this in a sustainable way, I am looking if we should fix the manylinux image provided via dockcross |
See pypa/auditwheel#102 See https://circleci.com/gh/scikit-build/ninja-python-distributions/344 Thanks @kjerstadius for investigating the issue. See #18
See pypa/auditwheel#102 See https://circleci.com/gh/scikit-build/ninja-python-distributions/344 Thanks @kjerstadius for investigating the issue. See scikit-build#18
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 1 1
Lines 23 23
Branches 3 3
=======================================
Hits 20 20
Partials 3 3Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 1 1
Lines 23 23
Branches 3 3
=======================================
Hits 20 20
Partials 3 3Continue to review full report at Codecov.
|
2 participants
The pattern argument to listdir() has been deprecated in favor of the
match argument. They don't function in the exact same way as match
expects a callable that will be used for matching.