Skip to content

Conversation

henryiii
Copy link
Collaborator

  • fix: missing lib is warning, not error
  • fix: warn if scripts included with potentially invalid shebangs

See #130.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii enabled auto-merge (rebase) November 23, 2022 05:25
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #132 (9a19719) into main (8b0aae7) will decrease coverage by 0.14%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   90.60%   90.46%   -0.15%     
==========================================
  Files          43       43              
  Lines        1724     1730       +6     
==========================================
+ Hits         1562     1565       +3     
- Misses        162      165       +3     
Impacted Files Coverage Δ
src/scikit_build_core/build/wheel.py 91.22% <66.66%> (-1.37%) ⬇️
src/scikit_build_core/builder/sysconfig.py 82.05% <100.00%> (ø)
src/scikit_build_core/_logging.py 78.94% <0.00%> (-1.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit 7b53b7f into main Nov 23, 2022
@henryiii henryiii deleted the henryiii/fix/warnscript branch November 23, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant