Skip to content

fix: warn on scripts with invalid shebangs #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

fix: warn on scripts with invalid shebangs #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a9bf27
fix: missing lib is warning, not error
henryiii Nov 23, 2022
9a19719
fix: warn if scripts included with potentially invalid shebangs
henryiii Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/scikit_build_core/build/wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,15 @@ def build_wheel(
exclude=settings.sdist.exclude,
)

for item in wheel_dirs["scripts"].iterdir():
with item.open("rb") as f:
content = f.read(len(b"#!python"))
if content.startswith(b"#!/") and not b"#!python" != content:
logger.warning(
"Files in scripts/ are not post-processed yet for shabang fixes"
)
break

_write_wheel_metadata(packages_dir=wheel_dirs["platlib"], metadata=metadata)

tags = WheelTag.compute_best(
Expand Down
2 changes: 1 addition & 1 deletion src/scikit_build_core/builder/sysconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def get_python_library() -> Path | None:
if libpath.is_file():
return libpath

logger.error(
logger.warning(
"Can't find a Python library, got libdir={}, ldlibrary={}, multiarch={}, masd={}",
libdir,
ldlibrary,
Expand Down