chore: update to CMake 3.25 #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/cmake_25
branch
from
129c3f5 to
e83fe16
Compare
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 43 43
Lines 1732 1732
=======================================
Hits 1568 1568
Misses 164 164 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating examples
and built-in backportto 3.25.@jcfr and @thewtex, backporting was broken in 3.25 (and we need it for the SOABI fix from 3.26, and probably ABI3 if that's added, etc). See https://gitlab.kitware.com/cmake/cmake/-/issues/24185. If upstream is unwilling to fix it, we might have to maintain our own fork. :(