Conversation
hameerabbasi
force-pushed
the
find-python
branch
3 times, most recently
from
53d59d4 to
9df6eb0
Compare
hameerabbasi
force-pushed
the
find-python
branch
2 times, most recently
from
e4ea453 to
2601aa7
Compare
| install(TARGETS ${python_module_name} DESTINATION .) | ||
|
|
||
| # Quiet a warning, since this project is only valid with SKBUILD | ||
| set(ignoreMe "${SKBUILD}") |
There was a problem hiding this comment.
Technically, we now have a lot of variables that are going to produce warnings (this is why I haven't applied this sort of a fix yet. But I think it's fine, and I have a long term idea for fixing these warnings). Not sure it makes sense to just quiet this one anymore. But again, not for this PR.
|
I've gone through and applied the simple fixes suggested in the review. |
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
I think this is good. We sadly will produce unused variable warnings, but that's unavoidable for now, and I think I have a general solution to be applied later. I think we should get this in so we get it into a final Python 2 release. Thanks!
|
We'll need to rebase #485 on this, so let's get it in. Thank you! |
2 participants
Closes #506 and closes #516 and closes #553.