Skip to content

Conversation

@joequant
Copy link

@joequant joequant commented Dec 1, 2024

No description provided.

@HDembinski
Copy link
Member

Hi @joequant this looks reasonable, but a bit of documentation would be nice.

I see in (1) here https://en.cppreference.com/w/cpp/io/basic_stringstream/str
that the signature indeed changes with C++20. It therefore looks to me that your condition is not sufficient. This chance should affect all compilers eventually, therefore it seems _GLIBCXX_USE_CXX11_ABI is not the right thing to put into the condition.

@HDembinski HDembinski closed this Sep 19, 2025
@HDembinski
Copy link
Member

Closing this for lack of response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants