Pyright showing errors

[acampove]

Vector Version

1.6.2

Python Version

3.12

OS / Environment

Alma9

Describe the bug

When using MomentumObject4D I see:

These messages seem to be coming from pyright. My guess is that there is something deep in this vector class that is using (or not using) the wrong typehinting. I am also not sure where __new__ is coming from, we never call __new__ to intialize classes, we call __init__.

This is not breaking the code AFAIK. But we should not have errors like this all over the place.

Any additional but relevant log output

No response

[acampove]

I am also seeing things like:

so it seems that adding 2 MomentumObject4D gives me a VectorProtocol? Shouldn't adding two objects of a given type, give me another object of that type? Maybe what you did makes sense, but it is confusing the type analyzer when I use pyright.

[Saransh-cpp]

Hi @acampove 👋🏽 -

1. Vector is type checked using mypy and not pyright as mypy is the more popular/recommended (at least by scientific-python) static typing framework. We have no plans of supporting pyright.
2. I cannot debug your errors if I do not have a MWE. We do not plan to support pyright, but if you attach a MWE, I can always take a look at your code to see what's going wrong 🙂
3. "I am also not sure where __new__ is coming from, we never call __new__ to intialize classes, we call __init__."
   This will depend on the vector backend you're using (cannot help unless I have a MWE). __new__ can in fact be used to initialize an instance/object of a class and we use it within vector in a few places.
4. "adding 2 MomentumObject4D gives me a VectorProtocol"
   I cannot reproduce this locally with mypy.

I'll close this for now (bug (unverified) as no MWE + wontfix as no plans of supporting pyright), but please feel free to re-open/add more context.