Fixed multiple log handlers #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During hyperparameter optimisation of a hiclass classifier, HierarchicalClassifier._create_logger() adds a new StreamHandler to the logger every time it is instantiated. This means that on the nth iteration, every log line in the console is repeated n times. By checking if a hander is already set on the logger, we can skip adding another one when we call _create_logger()
Collaborator
|
Hi @flo-ri-an, This is a nice contribution! Thank you very much! I am not sure why the tests did not run, but I believe it is safe to merge. Kind regards, |
Contributor
Author
|
You're welcome ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During hyperparameter optimisation of a hiclass classifier,
HierarchicalClassifier._create_logger()adds a newStreamHandlerto the logger every time a classifier is instantiated. This means that on the nth iteration of a hyperparameter tuning session (or indeed any time a hiclass classifier is instantiated repeatedly) every log line in the console is repeated n times.By checking if a hander is already set on the logger, we can skip adding another one when
_create_logger()is callled