Skip to content

Conversation

@floriankozikowski
Copy link
Contributor

@floriankozikowski floriankozikowski commented Jun 23, 2025

Context of the PR

This PR adresses Issue #317

Contributions of the PR

  • Adds a new PoissonGroup class to /skglm/datafits/group.py for Poisson regression with group penalties.
  • Implements group-wise gradient and sparse gradient methods for the Poisson datafit.
  • temporary toy script to play with the datafit in /debug_poisson_group.py

Checks before merging PR

  • added documentation for any new feature
  • added unit tests
  • edited the what's new (if applicable)

@@ -0,0 +1,30 @@
import numpy as np
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you come up with a unit test (I don't see an easy one right now) to get more rigorous testing ?

@floriankozikowski floriankozikowski marked this pull request as ready for review June 24, 2025 15:38
@mathurinm mathurinm requested a review from Badr-MOUFAD June 27, 2025 14:11
@mathurinm mathurinm merged commit 3851715 into scikit-learn-contrib:main Jul 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants