MAINT Add parameter validation to RFE and RFECV.#24137
Merged
thomasjpfan merged 4 commits intoscikit-learn:mainfrom Aug 29, 2022
Merged
MAINT Add parameter validation to RFE and RFECV.#24137thomasjpfan merged 4 commits intoscikit-learn:mainfrom
thomasjpfan merged 4 commits intoscikit-learn:mainfrom
Conversation
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
reviewed
Aug 29, 2022
Comment on lines
+631
to
+632
| _parameter_constraints = { | ||
| **RFE._parameter_constraints, # type: ignore |
Member
There was a problem hiding this comment.
For me, mypy passes without the # type: ignore comment. Do you see a mypy error without the comment?
Member
There was a problem hiding this comment.
I'll merge this first, because using # type: ignore is consistent with what other estimators are doing.
I opened #24301 to address this typing issue everywhere.
thomasjpfan
approved these changes
Aug 29, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #23462
What does this implement/fix? Explain your changes.
Add parameter validation to RFE and RFECV.
Any other comments?