MAINT Parameters validation for AdditiveChi2Sampler#24149
Merged
jeremiedbb merged 11 commits intoscikit-learn:mainfrom Aug 30, 2022
Merged
MAINT Parameters validation for AdditiveChi2Sampler#24149jeremiedbb merged 11 commits intoscikit-learn:mainfrom
jeremiedbb merged 11 commits intoscikit-learn:mainfrom
Conversation
Micky774
reviewed
Aug 26, 2022
Micky774
reviewed
Aug 26, 2022
Micky774
reviewed
Aug 26, 2022
Contributor
|
Aside from the final remaining cosmetic changes, this looks good to me |
Contributor
Author
|
@Micky774 thank you for the feedback, all the changes have been done |
jeremiedbb
approved these changes
Aug 30, 2022
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Thanks @amitalokbera
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #23462
What does this implement/fix? Explain your changes.
Parameters validation for AdditiveChi2Sampler
Any other comments?
None