Skip to content

DOC add missing docstring in functions in hgbt module#24191

Merged
thomasjpfan merged 2 commits intoscikit-learn:mainfrom
lorentzenchr:hgbt_docstrings
Aug 17, 2022
Merged

DOC add missing docstring in functions in hgbt module#24191
thomasjpfan merged 2 commits intoscikit-learn:mainfrom
lorentzenchr:hgbt_docstrings

Conversation

@lorentzenchr
Copy link
Copy Markdown
Member

Reference Issues/PRs

This popped up in a review of #21020 (comment).

What does this implement/fix? Explain your changes.

Add missing docstring entries in the histogram gradient boosting submodule (attributes, parameters).

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 9aae2ad into scikit-learn:main Aug 17, 2022
@lorentzenchr lorentzenchr deleted the hgbt_docstrings branch August 17, 2022 13:49
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants