DOC Ensures that strip_accents_unicode passes numpydoc#24232
Merged
thomasjpfan merged 3 commits intoscikit-learn:mainfrom Aug 24, 2022
Merged
DOC Ensures that strip_accents_unicode passes numpydoc#24232thomasjpfan merged 3 commits intoscikit-learn:mainfrom
thomasjpfan merged 3 commits intoscikit-learn:mainfrom
Conversation
CloseChoice
changed the title
CloseChoice
changed the title
thomasjpfan
changed the title
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Contributor
Author
Thanks for reviewing, done. |
thomasjpfan
changed the title
thomasjpfan
changed the title
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…24232) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
No errors were thrown for strip_accents_unicode. Therefore just removed it from the list of functions whose docstring should be ignored:
FUNCTION_DOCSTRING_IGNORE_LIST.Any other comments?
None, a simple enough first PR!
What does this implement/fix? Explain your changes.
Any other comments?