Merged
Conversation
Use `stacklevel=2` in _handle_errors to make warnings appear from the function that called _handle_errors, and call _handle_errors from _malloc_copy to check for possible KLUOutOfMemoryError.
This behavior is consistent with sksparse.umfpack, and is more convenient for the user to not have to invert the row-scaling factors. The reciprocal is only computed on output, not used internally.
This behavior change makes sksparse.umfpack consistent with klu and cholmod.
This change leaves CholeskyFactor in an "unsafe" state after __cinit__ is run (or `CholeskyFactor.__new__(CholeskyFactor)`), since the `_cm` and `_factor` pointers are NULL, but it would have to be very intentional on the part of the user to create an object as such. There is a warning in the docs.
Just use the __dealloc__ method directly.
Remove the memcpy calls, which also take the pointers.
This method allows the user to chang the factor from LL.T to LDL.T format, without any re-computation or copying the factor. It does not expose the other arguments to cholmod_change_factor.
broesler
force-pushed
the
release/v0.5.0
branch
from
ae5f54a to
45d5a1d
Compare
This commit replaces the original Factor.solve_LDLt, etc. methods beyond the standard system="A" for Ax = b.
broesler
force-pushed
the
release/v0.5.0
branch
from
45d5a1d to
5a92ebd
Compare
This commit does not change existing code, as the namedtuple has an iterator that cycles properly over "count, h, parent, post, L".
broesler
force-pushed
the
release/v0.5.0
branch
from
5a92ebd to
b9ef171
Compare
broesler
force-pushed
the
release/v0.5.0
branch
from
b9ef171 to
2f319a7
Compare
broesler
force-pushed
the
release/v0.5.0
branch
from
2f319a7 to
aca7108
Compare
This change ensures code still functions when users use "python -O" that ignores assert statements.
This update does not make any behavioral changes, but allows users to import just a single submodule at a time, in the case where all of SuiteSparse is not installed, or just for import efficiency.
This module is used in validate_csc_input to check the user's scipy version.
Also update the README to link to the migration table.
Also change project name from scikit-sparse-dev -> scikit-sparse.
broesler
force-pushed
the
release/v0.5.0
branch
from
aca7108 to
3425eaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines all of the new features and the CHOLMOD refactor in #138, #139, #141, #142, #143, #146, #147, #148, #149, and #151. I will close those individual PRs once this is merged.
I have listed the API changes, including bug fixes to the original, in the Change Log under
doc/changes.rst.I've also restructured the documentation to more closely resemble the NumPy/SciPy docs.
I have also opened a corresponding SciPy draft PR that shows how this new API would be integrated therein, and be ready for review once this PR is merged.