-
Notifications
You must be signed in to change notification settings - Fork 8
create a card_template.html to reduce the code repetition #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov ReportBase: 62.09% // Head: 62.09% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 62.09% 62.09%
=======================================
Files 21 21
Lines 1583 1583
=======================================
Hits 983 983
Misses 600 600 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
astrophpeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Sam, genreally really good. Looks like you have successfully removed repeated template code! I have two suggestions.
Could you please remove the extra ccs styling please?
Could you also remove the old code which you have commented out in various places?
for more information, see https://pre-commit.ci
|
extra css and old code are removed. |
astrophpeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, will merge shortly!
create a card_template.html to reduce the code repetition
Fixes #40
Description of the Change
I create a new template html file named card_template.html. After that, I change the design of all card.html files and follow the style of card_templates to reduce the code repetition.
Checklist
Please check all that apply to your proposed changes
Additional context