Skip to content

Conversation

@SamLaiiii
Copy link
Contributor

Fixes #40

Description of the Change

I create a new template html file named card_template.html. After that, I change the design of all card.html files and follow the style of card_templates to reduce the code repetition.

Checklist

Please check all that apply to your proposed changes

  • HTML code change
  • Added package dependency
  • Added data
  • Changed django model
  • Documentation change
  • Added or changed TaskRunner

Additional context

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 62.09% // Head: 62.09% // No change to project coverage 👍

Coverage data is based on head (ac23c4b) compared to base (7152702).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   62.09%   62.09%           
=======================================
  Files          21       21           
  Lines        1583     1583           
=======================================
  Hits          983      983           
  Misses        600      600           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@astrophpeter astrophpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Sam, genreally really good. Looks like you have successfully removed repeated template code! I have two suggestions.

Could you please remove the extra ccs styling please?
Could you also remove the old code which you have commented out in various places?

@SamLaiiii
Copy link
Contributor Author

extra css and old code are removed.

Copy link
Contributor

@astrophpeter astrophpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, will merge shortly!

@astrophpeter astrophpeter merged commit f83872d into main Sep 23, 2022
@astrophpeter astrophpeter deleted the SamLai branch September 23, 2022 14:43
djones1040 pushed a commit that referenced this pull request Jul 30, 2023
create a card_template.html to reduce the code repetition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor card html templates

3 participants