Add SymbolInformation for local symbols per SCIP spec#167
Merged
Conversation
According to the SCIP specification, Document.symbols should contain all symbols defined within the document, including local symbols (local variables, parameters, etc.). Local symbols use the format 'local <id>' and must be included in Document.symbols for proper SCIP compliance. This change adds SymbolInformation entries for all local symbols to each document, fixing scip lint errors about missing symbol definitions for local 0, local 1, etc. Per scip.proto: - Document.symbols: 'Symbols that are defined within this document' (line 91) - Local symbols 'MUST only be used for entities which are local to a Document' (line 187-188) Amp-Thread-ID: https://ampcode.com/threads/T-9333bd1b-1af9-443f-9d31-4cce0fc688f0
varungandhi-src
suggested changes
Sep 26, 2025
Contributor
varungandhi-src
left a comment
varungandhi-src
left a comment
There was a problem hiding this comment.
I think it's good to fix this error, but testing-wise, I think it'd be better to take a different approach.
varungandhi-src
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
scip lintissue of missing local symbol definitions (there is still an issue of missing external symbols).According to the SCIP specification,
Document.symbolsshould contain all symbols defined within the document, including local symbols (local variables, parameters, etc.). Local symbols use the format 'local ' and must be included inDocument.symbolsfor proper SCIP compliance.This change adds
SymbolInformationentries for all local symbols to each document, fixing scip lint errors about missing symbol definitions for local 0, local 1, etc.Also added
AGENTS.md.