Conversation
jupblb
force-pushed
the
michal/scip-0.7.1
branch
from
0d75811 to
4863cb5
Compare
Multiple case clauses in a type switch share the same obj.Pos(),
so caseClauses[obj.Pos()] = obj was last-write-wins on a Go map,
producing random types (bool vs interface{}) across runs.
Skip SignatureDocumentation for type-switch locals since the per-case
type info is already emitted via override_documentation on references.
jupblb
force-pushed
the
michal/scip-0.7.1
branch
from
5b4f821 to
9e7fd8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.