Conversation
…TypeName pattern Adds support for *ast.IndexExpr (single type param), *ast.IndexListExpr (multiple type params), and *ast.ParenExpr. Removes panic on unexpected receiver list length.
Replace manual index-based iteration with Go 1.24 iterator methods in listMethods and canonicalizeMethod.
…trimming PkgNameOf (Go 1.22) reliably resolves the imported package via the type checker, replacing the manual strings.Trim of the import path literal.
jupblb
force-pushed
the
michal/simplify
branch
2 times, most recently
from
e67c623 to
1022fea
Compare
Use go/types.Implements for interface satisfaction checking instead of reimplementing it with canonicalized method strings and intsets.Sparse bitsets. This correctly handles all edge cases (embedded types, generics, unexported methods from different packages). Method correlation after implementation check now uses types.Id (the standard Go method identity) instead of custom canonical signatures. Removes canonicalizeMethod, implementationsForType, and the intsets dependency from this package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.