Skip to content

fixes snapshot generator comment // insertion#120

Merged
Strum355 merged 2 commits into
mainfrom
nsc/snapshot-comment-fix
Mar 9, 2021
Merged

fixes snapshot generator comment // insertion#120
Strum355 merged 2 commits into
mainfrom
nsc/snapshot-comment-fix

Conversation

@Strum355

@Strum355 Strum355 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

You can see the change this has by looking at the committed snapshot files 🙂

For cases where there is no 1 or more whitespace of leeway, we cut down the number of ^ by one. This mostly affects type decls, who's ranges need to be fixed anyways and annotations on decls

@olafurpg olafurpg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread tests/unit/src/main/scala/tests/SemanticdbPrinters.scala Outdated
Co-authored-by: Ólafur Páll Geirsson <olafurpg@gmail.com>
@Strum355 Strum355 merged commit aef7bdb into main Mar 9, 2021
@Strum355 Strum355 deleted the nsc/snapshot-comment-fix branch March 9, 2021 17:47
Strum355 added a commit that referenced this pull request Mar 9, 2021
* fixes snapshot generator comment // insertion

Co-authored-by: Ólafur Páll Geirsson <olafurpg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants