replace emitting MarkedString[] with MarkupContent#179
Merged
Conversation
Strum355
force-pushed
the
nsc/markupcontent
branch
from
2b9d024 to
c8f8fb0
Compare
48 tasks
olafurpg
suggested changes
Apr 23, 2021
olafurpg
left a comment
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
Mostly minor comments, otherwise looks good.
| contents <- hoverResult.getContentsList.asScala | ||
| } yield contents.getValue.trim | ||
| sym -> hoverMessage.mkString("\n\n") | ||
| val hover = |
Contributor
There was a problem hiding this comment.
Nit: for comprehensions become hard to read when you add a complicated chain of operations on top of it. I think this diff would read cleaner by keeping the original for comprehension and adding a separate statement instead
Strum355
force-pushed
the
nsc/markupcontent
branch
from
c8f8fb0 to
6fe81fa
Compare
olafurpg
approved these changes
Apr 26, 2021
olafurpg
left a comment
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
I took the liberty to push a commit updating the for-comphrension. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #162
Required some work in SnapshotLsifCommand.scala due to the new format. Also fixed a load of lint errors that Intellij kept throwing at me 🙃