handle unresolved annotation parameter tree differences#191
Merged
Conversation
olafurpg
approved these changes
Apr 27, 2021
olafurpg
left a comment
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 It would be nice to have a targeted test case, if only to validate that we can test code with compile errors. However, I'm OK with merging this without tests. It's always good to get rid of unsafe casts
| import java.util.*; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import static com.sourcegraph.semanticdb_javac.Debugging.pprint; |
Contributor
Author
|
Tried recreating the issue in an isolated case, but even there I would get a JCAssign tree 😞 |
Strum355
force-pushed
the
nsc/unresolved-annotation-fix186
branch
from
91f60be to
c6b83d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain situations when an annotation symbol cannot be resolved, the tree types of parameters are not
JCAssign.This PR addresses the cast exceptions caused by this.
The
SignatureFormatteris also modified to accept the new semanticdb output but from what I have seen, the codepaths arent reached for those unresolved annotations (typically getting the__root__/symbol).Closes #186