Several PackageHub fixes#193
Merged
Merged
Conversation
Fixes scip-code#187 The error message creates noise in our logs so it's better to ignore it. Some repos may have no Java sources and that's fine, there's no need to fail the build because there's nothing we can do to index that repo.
Fixes scip-code#189 Previously, you didn't get the output from running javac when sending a POST request to PackageHub. Now, the javac output is returned to the client that sends the POST request.
Fixes scip-code#188 Some libraries don't publish sources. This commit updates the validation logic when we add a new package to the database so that we only add package that publish sources. We also fix the LSIF indexing logic to silently ignore repos that have missing sources.
Fixes scip-code#190 Some packages include the pom.xml file in the published sources, causing the `lsif-java index` command to fail because it auto-detected both a Maven build and the lsif-java.json build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.