Fix bug for cross-repo navigation to the JDK sources.#212
Merged
Conversation
Previously, the generated LSIF pointed to a non-existing repo "jdk:8" causing goto definition to stop working for JDK symbols.
Previously, error messages from `javac` would not appear when auto-indexing a `lsif-java.json` build. Now, the error message is reported with the reporter making it available in the console, and it's also available in the HTTP response when indexing via PackageHub.
Previously, PackageHub was unable to auto-index the JDK 11 sources because it was missing appropriate `--module` flags that are not needed for JDK 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the generated LSIF pointed to a non-existing repo "jdk:8"
causing goto definition to stop working for JDK symbols.