Use "local" instead of "import" for local symbol monikers.#228
Merged
Conversation
Previously, lsif-java used "kind: import" for local symbols. The Sourcegraph backend stores all import/export monikers in the postgres database. This change make the kind "local" so that they don't get stored in the Postgres backed, reducing disk usage.
olafurpg
commented
May 21, 2021
| val docPath = AbsolutePath | ||
| .of(Paths.get(doc.getUri), sourceroot) | ||
| .toRealPath() | ||
| .normalize() |
Contributor
Author
There was a problem hiding this comment.
This change was necessary to get the snapshots testing passing on macos. We don't run the CI on macos, but might want to reconsider that if we hit on more linux/macos issues like this.
| │ │ │ │ │ │ | ||
| v v v │ v v | ||
| ╭────────────╮ ╭───────────┴──────╮ ╭───────────────────────────────────╮ | ||
| │local local0│ │range(50) 3:34 'n'│ │hoverResult(54) ```java\nint n\n```│ |
Contributor
Author
There was a problem hiding this comment.
You can ignore the rest of the diff in this file, the most interesting bit is local local0 to indicate we now use the local kind for local symbols
efritz
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, lsif-java used "kind: import" for local symbols. The
Sourcegraph backend stores all import/export monikers in the postgres
database. This change make the kind "local" so that they don't get
stored in the Postgres backed, reducing disk usage.