Tweak ANSI color output #230
Merged
Merged
Conversation
This version includes a fix so that `NO_COLOR=true` should be properly respected now.
This flag has existed longer than `--no-transfer-progress` and it achieves roughly the same effect (removes verbose output)
This disables progress bars that produce verbose console output.
Strum355
approved these changes
May 24, 2021
Strum355
left a comment
Strum355
left a comment
Contributor
There was a problem hiding this comment.
Curious if you wanna disable it only when we set NO_COLOR, so we can still get colour when running in an interactive term 🙂 but thats up to you, just a thought
Previously, the tests assumed that the output from Gradle/Maven went
straight to `System.{out,error}`. Now, the output goes through Moped and
it gets captured for testing purposes.
Contributor
Author
|
@Strum355 I thought about it but it didn't feel worth the development effort. Most users run lsif-java in CI and I think it makes sense to enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, lsif-java used default color output settings when shelling out to Maven and Gradle. Now, lsif-java uses --batch-mode for Maven and
TERM=dumbfor Gradle to reduce ANSI color output (helpful for CI logs). Additionally, we upgrade to the latest moped release so that settingNO_COLOR=truedisables all ANSI colors (including output from lsif-java).The motivation for this PR was to reduce noise in the Sourcegraph auto-indexing CI logs, which currently render ANSI escape codes.