Replace snapshot printer with scip CLI#910
Merged
Merged
Conversation
Render snapshots via `scip snapshot` (pinned scip-code/scip flake input, added to the dev shell) instead of the in-repo ScipPrinters; regenerate Java and Kotlin goldens.
kotlincSnapshots wrote index.scip into the scanned targetroot, so re-runs re-aggregated it and doubled the package prefix (`scip-java maven . . scip-java maven . . ...`). Write the index to a separate dir and regenerate the affected goldens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the in-repo
ScipPrinterssnapshot renderer with thescipCLI'ssnapshotcommand, added to the dev shell and pinned via thescip-code/scipflake input. Java and Kotlin golden snapshots are regenerated in scip's format.Accepted format changes:
enclosing_symbollines and multiline-occurrence annotations are dropped;signature_documentationbecomes>blocks;enclosing_rangemarkers are preserved.