Include diagnostics in snapshot output#226
Merged
Merged
Conversation
Contributor
Author
|
This PR is based on #220, with the following differences:
|
Contributor
|
Nice work. I noticed that we were truncating the multiline output for docs (and you probably copied that for the diagnostic message), which seems like undesirable behavior from the POV of an indexer as you want to make sure the full contents are correct. So I've tweaked that. |
408be80 to
271649c
Compare
Contributor
|
Rebased on include the build failure fix from #228 |
This was referenced Jan 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds diagnostic information to the snapshot output to support
testing. To make it possible to test this in the SCIP repo, it updates the
reprolang generator to output a diagnostic for every identifier that starts
with 'deprecated'.
Example output:
Closes #213
Test plan
New snapshot test to check diagnostics output