Tidy each Go module instead of go work sync#413
Merged
Conversation
jupblb
changed the title
go work syncgo work sync
`go work sync` propagates require directives across workspace modules
but does not add the `/go.mod h1:` checksum lines that newly-introduced
transitive deps need, so the downstream Nix build still fails with:
missing go.sum entry for go.mod file; to add it:
go mod download <module>
Run `go mod tidy` in each module instead. Tidy bindings/go/scip first
because root and reprolang pull it in via `replace`.
jupblb
force-pushed
the
michal/tidy-each-module
branch
from
7347130 to
b24f0ff
Compare
jupblb
force-pushed
the
michal/tidy-each-module
branch
3 times, most recently
from
3e940fc to
020cde1
Compare
actions/setup-go installs the exact patch version from go.mod (1.25.0) while the Nix build uses pkgs.go from the locked nixpkgs (currently 1.25.6); even patch-level skew can mutate go.sum differently than the build expects. Drop setup-go and run `go mod tidy` under `nix shell --inputs-from . nixpkgs#go` so tidy uses exactly the toolchain the Nix build will use.
jupblb
force-pushed
the
michal/tidy-each-module
branch
from
020cde1 to
dcd4a51
Compare
eseliger
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go work syncpropagates require directives across workspace modules but does not add the/go.mod h1:checksum lines that newly-introduced transitive deps need, so the downstream Nix build still fails with:missing go.sum entry for go.mod file; to add it:
go mod download
Run
go mod tidyin each module instead. Tidybindings/go/scipfirst because root andreprolangpull it in viareplace.