Clean up reprolang's grammar#433
Merged
Merged
Conversation
- Fix '# doctring:' typo in parser.go that compensated for itself by accident (lengths matched). - Fix README claim about a 'global' keyword that never existed. - Rename field 'roles' to 'relations' to match SCIP terminology. - Drop '_relation' suffix from rule names (implements, references, type_defines, defined_by). - Promote 'forward_definition' to its own rule. - Drop explicit '\n' statement terminator; extras already handle it.
Extract parseDocstring and parseRelations helpers so each function has one responsibility. The dispatch loop now reads as a flat switch. Re-add 'forward_definition' as a field on reference_statement so Go can detect it with a one-line ChildByFieldName check (no longer self-referential now that forward_definition is its own rule).
eseliger
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor cleanup. Ideally we can cover more SCIP features in reprolang in the future.