Trying to fix macOS wheels#1217
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the macOS wheel build configuration (cibuildwheel) to avoid delocate-wheel failures on newer GitHub macOS runners by lowering the deployment target and rewriting bundled dylib build-version metadata to match.
Changes:
- Set
MACOSX_DEPLOYMENT_TARGET=11.0for macOS wheel builds/repairs. - Add a pre-repair step to rewrite
LC_BUILD_VERSIONfor bundled SCIP/SoPlex/GCG dylibs and selected Homebrew GCC runtime dylibs viavtool, then re-sign. - Document the macOS wheel change in the changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates cibuildwheel macOS build/repair scripts to target macOS 11.0 and patch dylib build-version metadata for delocate compatibility. |
| CHANGELOG.md | Adds a release note describing the macOS deployment target change and dylib patching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Wheels are passing on this branch. |
Member
Author
|
Alright, this passes the wheels and it has been verified by both Mark and I. Will merge and create the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.