Properly match TDC name#30
Merged
Merged
Conversation
nvaytet
approved these changes
Sep 11, 2024
Member
nvaytet
left a comment
nvaytet
left a comment
There was a problem hiding this comment.
Slightly annoying diff to read... ;-)
| def validate(self, node: Dataset | Group) -> Violation | None: | ||
| if node.name == 'top_dead_center': | ||
| if 'value' in node.children: | ||
| if node.name.rsplit("/", 1)[-1] == "top_dead_center": |
Member
There was a problem hiding this comment.
I never know if rsplit or endswith("/top_dead_center") is better...
Member
Yes, next time, please reject PRs that have unrelated (and unintentional) big formatting changes! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup for #29
Failing test in https://git.esss.dk/dmsc-nightly/dmsc-nightly/-/jobs/42815#L83