feat: check that event_id in associated detector_number#37
Merged
Conversation
jl-wynen
reviewed
Oct 25, 2024
| isinstance(node, Group) | ||
| and node.attrs.get('NX_class') == 'NXevent_data' | ||
| and 'event_id' in node.children | ||
| and 'detector_number' in node.parent.children |
Member
There was a problem hiding this comment.
Are we separately checking that event_id and detector_number exist? Or is it ok when they don't and we can load the file anyway?
Contributor
Author
There was a problem hiding this comment.
We don't have validators that makes sure event_id and detector_number exists at the moment.
Or is it ok when they don't and we can load the file anyway?
I don't know. Maybe we should create an issue for that.
jokasimr
force-pushed
the
events-in-detector-nums
branch
2 times, most recently
from
a319d37 to
30d9a9c
Compare
Contributor
Author
|
jokasimr
force-pushed
the
events-in-detector-nums
branch
from
a8c4fb1 to
666fa8a
Compare
jl-wynen
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
Just like #36 this requires reading the values of datasets.