There are two issues with how the sample rotation is encoded:
-
The workflow uses NXcrystal to identify the sample rotation. That class is meant for analysers (monochromators). So our code should be changed to use NXsample.
-
The sample rotation is stored as a Position. But that is not accurate, there should be a dedicated rotation / angle type. In spectroscopy we use this: https://github.com/scipp/essspectroscopy/blob/8676040cb9c693f8a5d7d84330fe5c0b87119db4/src/ess/spectroscopy/types.py#L114 We should move this into ESSreduce and optionally rename it if others prefer 'rotation' over 'angle'.
There are two issues with how the sample rotation is encoded:
The workflow uses
NXcrystalto identify the sample rotation. That class is meant for analysers (monochromators). So our code should be changed to useNXsample.The sample rotation is stored as a
Position. But that is not accurate, there should be a dedicated rotation / angle type. In spectroscopy we use this: https://github.com/scipp/essspectroscopy/blob/8676040cb9c693f8a5d7d84330fe5c0b87119db4/src/ess/spectroscopy/types.py#L114 We should move this into ESSreduce and optionally rename it if others prefer 'rotation' over 'angle'.