Skip to content

[ESSnmx] Use more accurate domain types for sample #254

@jl-wynen

Description

@jl-wynen

There are two issues with how the sample rotation is encoded:

  1. The workflow uses NXcrystal to identify the sample rotation. That class is meant for analysers (monochromators). So our code should be changed to use NXsample.

  2. The sample rotation is stored as a Position. But that is not accurate, there should be a dedicated rotation / angle type. In spectroscopy we use this: https://github.com/scipp/essspectroscopy/blob/8676040cb9c693f8a5d7d84330fe5c0b87119db4/src/ess/spectroscopy/types.py#L114 We should move this into ESSreduce and optionally rename it if others prefer 'rotation' over 'angle'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    essnmxIssues for essnmx.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions