Move helper functions to conftest.#253
Closed
YooSunYoung wants to merge 1 commit intocheck-test-file-namesfrom
Closed
Move helper functions to conftest.#253YooSunYoung wants to merge 1 commit intocheck-test-file-namesfrom
YooSunYoung wants to merge 1 commit intocheck-test-file-namesfrom
Conversation
jl-wynen
reviewed
Mar 18, 2026
Member
There was a problem hiding this comment.
Can you use more explicit fixture names? no_detectors doesn't say anything about what type of data it contains. And you can use a conftest.py in the mcstas subfolder to give the fixtures a more narrow scope.
Member
|
Maybe you should base this branch on main. That way, CI doesn't fail because of the file name in essreduce. |
Member
Author
|
I'll close this in favor of #255 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the non-test-python-file to conftest.
It's better this way I think?