Conversation
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| package: |
There was a problem hiding this comment.
Does it make sense to use a choice type here (https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onworkflow_dispatchinputs) That way, the caller can't make a typo. But we would have to maintain the list as we add packages.
There was a problem hiding this comment.
We had a list before, so I think it would be ok to have a choice here? especially if it translates to a dropdown menu in the web ui?
There was a problem hiding this comment.
We have 3 workflows that build docs, 2 of them also publish the docs to different places. Can we merge these into a reusable workflow and call that from CI, releases, and the web UI?
There was a problem hiding this comment.
Yes, that's what I felt when I was trying to fix this.
But I felt it would be complicated to get right first time, and I did not want this to block releases for the other packages.
So we can fix as a follow-up?
Co-authored-by: Jan-Lukas Wynen <jan-lukas.wynen@ess.eu>
|
Note that CI fails because I manually stopped it, wasn't worth using up more CI time for the latest commit. |
* feat: load 3D detector geometry * feat: load monitor * fix: same interface for loading old and new files + replace DetectorBank index with enum * refactor: tofectomy * fix * docs: tweak wording * feat: powder diffraction workflow for beer * fix * fix: remove theta masking during load * docs: raw detector does not have scattering angle any more * fix: remove unused two theta limits * docs: naming * fix * refactor: self explanatory name * docs: make separate quantity for wavelength definition chopper position * docstring
2 participants
The change in the docs build
was not propagated everywhere.
Here we fix it, and also change the
docs-deploy.ymlworkflow to just build for a selected package.