Skip to content

[REFLECTOMETRY] Add essreflectometry package#275

Merged
jokasimr merged 899 commits intomainfrom
add-essreflectometry
Apr 16, 2026
Merged

[REFLECTOMETRY] Add essreflectometry package#275
jokasimr merged 899 commits intomainfrom
add-essreflectometry

Conversation

@jokasimr
Copy link
Copy Markdown
Contributor

@jokasimr jokasimr commented Apr 14, 2026

No description provided.

nvaytet and others added 30 commits August 7, 2025 14:49
@nvaytet
cleanup
6e9ae03
@nvaytet
do not fail if UnscaledReducibleData is not in graph
f90fe86
@nvaytet
modify the WorkflowCollection to just use cyclebane mapping under the…
5587e68 
… hood and make its interface more like the Pipeline interface rather than a mix between Pipeline and a dict
@nvaytet
formatting
a01379e
@nvaytet
update amor notebook
c2340d5
@nvaytet
debugging compute multiple
d4f5cbf
@jokasimr
docs: add grid information
4dfcb9d
@jokasimr
Merge branch 'provider-for-qbins' of github.com:scipp/essreflectometr…
4794fc9 
…y into provider-for-qbins
@jokasimr
fix: better default number of bins
863bd0b
@jokasimr
Merge branch 'main' into provider-for-qbins
b07bb07
@jokasimr
Merge pull request #170 from scipp/provider-for-qbins
7b311b6 
Provider for qbins
@nvaytet
fix compute
686d229
@jokasimr
Merge branch 'main' into gui-select-reference
1a1096c
@jokasimr
deps
b51bea1
@jokasimr
Merge remote-tracking branch 'origin/main' into polcal
86114d6
@jokasimr
deps: add esspolarization
cf15ac9
@jokasimr
fix
b2e420c
@jokasimr
fix: link directly do doi page - other link breaks
fb50863
@jokasimr
fix: remove old Q and theta coords before setting coords based on sam…
d9a5ac4 
…ple rotation
@jokasimr
Merge branch 'polcal' of github.com:scipp/essreflectometry into polcal
074e5f2
@jokasimr
fix: remove url
9ef8a30
@jokasimr
fix: supermirror params
65815fa
@jokasimr
fix
e41c8d2
@jokasimr
Merge pull request #173 from scipp/fix-link
d9ac4d6 
fix: link directly do doi page - other link breaks
@jokasimr
Merge branch 'main' into fix-estia-sm-params
a3405bf
@jokasimr
Merge pull request #174 from scipp/fix-estia-sm-params
4b5e85f 
fix: supermirror params
@jokasimr
Merge branch 'main' into gui-select-reference
a993ad7
@jokasimr
Merge branch 'main' into polcal
7dbbe33
@jokasimr
Merge pull request #169 from scipp/gui-select-reference
99db5ee 
feat: add reference column to reduction table
@jokasimr
Merge branch 'main' into polcal
2444259
@jokasimr jokasimr requested a review from MridulS April 14, 2026 07:40
@jokasimr jokasimr requested a review from YooSunYoung April 14, 2026 14:01
@jokasimr jokasimr mentioned this pull request Apr 14, 2026
Open
@nvaytet
Copy link
Copy Markdown
Member

nvaytet commented Apr 14, 2026

Nice 👍

I did not look at the full diff. I looked at the pixi.toml which looks fine.
The built docs for reflectometry also look good.

Remember to also transfer the issues using the script in #241

@jokasimr
Copy link
Copy Markdown
Contributor Author

jokasimr commented Apr 14, 2026

Remember to also transfer the issues using the script in #241

Done 👍

YooSunYoung
YooSunYoung reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@YooSunYoung YooSunYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove a few files...! I left a comment in them.

Comment thread packages/essreflectometry/CODE_OF_CONDUCT.md Outdated
Copy link
Copy Markdown
Member

@YooSunYoung YooSunYoung Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is in the top-level so we don't need it here.

Comment thread packages/essreflectometry/CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Member

@YooSunYoung YooSunYoung Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is in the top-level so we don't need it here.

Comment thread packages/essreflectometry/LICENSE Outdated
Copy link
Copy Markdown
Member

@YooSunYoung YooSunYoung Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is in the top-level so we don't need it here.

Comment thread packages/essreflectometry/bibliography.rst
Copy link
Copy Markdown
Member

@YooSunYoung YooSunYoung Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Copy link
Copy Markdown
Contributor Author

@jokasimr jokasimr Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the docs.

@nvaytet
Copy link
Copy Markdown
Member

nvaytet commented Apr 15, 2026

We can remove a few files...! I left a comment in them.

Maybe these should be added to the instructions ADDING_PACKAGES.md ?

@nvaytet
Copy link
Copy Markdown
Member

nvaytet commented Apr 15, 2026 •
edited
Loading

@jokasimr I didn't find any essreflectometry tags in the tags list.

Did you forget to do that part of the transfer? Maybe you retrieved the tags locally but forgot to do the git push origin --tags bit (which I now added to the instructions in #336 )?

@nvaytet nvaytet added the essreflectometry Issues for essreflectometry. label Apr 15, 2026
@jokasimr
Copy link
Copy Markdown
Contributor Author

jokasimr commented Apr 16, 2026

@nvaytet @YooSunYoung was there anything else to fix here or are we good to go?

@jokasimr jokasimr merged commit 815654f into main Apr 16, 2026
11 checks passed
@jokasimr jokasimr deleted the add-essreflectometry branch April 16, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YooSunYoung YooSunYoung YooSunYoung left review comments

@nvaytet nvaytet nvaytet approved these changes

@MridulS MridulS Awaiting requested review from MridulS

Assignees

No one assigned

Labels

essreflectometry Issues for essreflectometry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jokasimr @nvaytet @YooSunYoung @jl-wynen @paracini @MridulS