[NMX] Allow setting output time bin unit.#545
Merged
Conversation
YooSunYoung
changed the title
nvaytet
reviewed
Apr 30, 2026
|
|
||
| # Histogram detector counts | ||
| output_tunit = config.workflow.result_time_bin_unit | ||
| t_bin_edges = t_bin_edges.to(unit=output_tunit) |
Member
There was a problem hiding this comment.
If DIALS expects ns (the default), does it also expect integers?
I.e. if the output unit is ns, do we then need to convert also to int?
Member
Author
There was a problem hiding this comment.
I'm not sure... but it computes wavelength from the time again so shouldn't it prefer float...?
Member
Author
There was a problem hiding this comment.
I asked Aaron in person but for now we want to keep the dtypes the same as the older version, which is the float64.
jokasimr
approved these changes
May 11, 2026
YooSunYoung
force-pushed
the
nmx-output-t-unit
branch
from
fa629b9 to
6e82a1f
Compare
YooSunYoung
commented
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added output configuration to manually set output time bin unit.
At first, I thought it should be in the
outputconfiguration but then i realized it may be misleading when someone wants to usesave_resultsfunction separately... So I just added it toworkflowconfiguration.